×
Important information

To file a bug, find instructions here: Reporting bugs

Please only post images or files to this forum which you either own the copyright to or you are sure can be distributed under an open source license.

Limit on elements for main screen layout

More
03 Oct 2018 13:13 #71161 by Drones
I'm actually designing some custom layouts for my Jumper T8SG and I hit a limit of elements I can present on the main Screen.
Is this normal? It looks like there can only be 27? Is there a way to increase the number?

Even editing the model.ini and adding some extra elements everything above 27 is not shown on the main screen. The last 2 ones of the layout below don't actually show on the screen:

[gui-128x64]
Battery=86,39
V-trim=0,15,1
V-trim=124,15,2
H-trim=4,60,3
H-trim=75,60,4
Bargraph=7,36,Ch3
Bargraph=14,36,Ch4
Bargraph=21,36,Ch2
Bargraph=28,36,Ch1
Bargraph=39,36,Ch9
Bargraph=45,36,Ch10
Big-box=4,22,Ch3
Big-box=76,22,Timer1
Toggle=83,48,5,2,6,SW D
Toggle=91,48,5,2,6,SW B
Toggle=99,48,5,2,6,SW C
Toggle=107,48,5,2,6,SW A
Toggle=56,29,58,59,60,SW D
Toggle=64,29,61,61,61,SW D
Toggle=56,41,32,32,45,SW A
Toggle=64,41,33,33,47,SW A
Toggle=56,53,24,30,0,SW G
Toggle=64,53,25,31,0,SW G
Toggle=56,10,24,30,0,SW G
Toggle=64,10,25,31,0,SW G
Big-box=76,7,Timer2
Toggle=75,48,6,5,0,SW G
Toggle=115,48,5,6,0,SW H
Small-box=4,11,Ch12
Attachments:

Please Log in or Create an account to join the conversation.

More
03 Oct 2018 15:41 #71163 by hexfet
Replied by hexfet on topic Limit on elements for main screen layout
Looks like the default limit in config/pagecfg.h is 27. Not sure where that number comes from though maybe the nearby commented out code is a clue.
#ifndef NUM_ELEMS
    #define NUM_ELEMS (6 + 8 + 8 + 4 + 1)
#endif
//#define NUM_TRIM_ELEMS 6
//#define NUM_BOX_ELEMS 8
//#define NUM_BAR_ELEMS 8
//#define NUM_TOGGLE_ELEMS 4

However the limit is defined to be 50 for the devo12 in target/devo12/target_defs.h. You could try adding a similar definition to the t8sg target_defs.h. You'll need to build the firmware to make this change.

Please Log in or Create an account to join the conversation.

More
03 Oct 2018 16:00 #71165 by Drones
Replied by Drones on topic Limit on elements for main screen layout
Thanx a lot Hexfet, any chance this could be included in future nightly builds?

Please Log in or Create an account to join the conversation.

More
11 Oct 2018 01:47 #71278 by hexfet
Replied by hexfet on topic Limit on elements for main screen layout
Did you check if all the transmitters build with this change? If so please make a pull request. It only increases RAM usage so don't think there should be a problem.

Please Log in or Create an account to join the conversation.

More
11 Oct 2018 11:02 #71283 by Drones
Replied by Drones on topic Limit on elements for main screen layout
Hexfet, happened on all builds I tried, will try latest nightly today and let you know.
Sorry for being a Noob, how would I make a pull request if necessary?

Please Log in or Create an account to join the conversation.

More
11 Oct 2018 14:56 #71286 by hexfet
Replied by hexfet on topic Limit on elements for main screen layout
A pull request is what's used to ask that software changes you have made are added to the nightly builds. Have you changed the source code and built test versions using the instructions at the link above?

I like to encourage folks to try this themselves - we could use more devs :) Otherwise I'll add this change to my to-do list.

Please Log in or Create an account to join the conversation.

Time to create page: 0.351 seconds
Powered by Kunena Forum