publishing an intermediate release 3.1.0?

PhracturedBlue wrote: Unless Rbe wants to pick up and investigate bugs, and wants to use the forum to do so, filing bugs in this thread will not help draw my attention to them. Especially if I can't reproduce on the emulator. The discussion will move on, and I'll forget about them before getting a chance to test them. Please file bugs on bitbucket so I can track them and prioritize.

vlad_vy wrote: www.deviationtx.com/forum/3-feedback-que...s/865-reporting-bugs

PhracturedBlue wrote: Rbe,
Another bug for you to look at:
#431
...
I'm not sure what this is for. I guess the -32 is for the Devo8 header (which isn't the same size on the Devo10), but I'm not exactly sure of the intent here. If the image is too bug, it seems to drop it into the lower right corner of the screen. I'd think you would leave x and y alone, and just adjust w and h if the image doesn't fit on the screen. If you are trying to center the image than this won't work if the image is smaller, so I guess that isn't the intent.
My fix would be:

   if (type == ELEM_MODELICO) {
        if (*y + *h > LCD_HEIGHT) *h -= LCD_HEIGHT - (*y + *h);
        if (*x + *w> LCD_WIDTH)   *w -= LCD_WIDTH - (*x + *w);
    }

But I'm not sure that is what you intended.

PhracturedBlue wrote: Unless Rbe wants to pick up and investigate bugs, and wants to use the forum to do so, filing bugs in this thread will not help draw my attention to them. Especially if I can't reproduce on the emulator. The discussion will move on, and I'll forget about them before getting a chance to test them. Please file bugs on bitbucket so I can track them and prioritize.

rbe2012 wrote:

PhracturedBlue wrote:

   if (type == ELEM_MODELICO) {
        if (*y + *h > LCD_HEIGHT) *h -= LCD_HEIGHT - (*y + *h);
        if (*x + *w> LCD_WIDTH)   *w -= LCD_WIDTH - (*x + *w);
    }

   if (type == ELEM_MODELICO) {
        if (*y + *h > LCD_HEIGHT) *h = LCD_HEIGHT - *y;
        if (*x + *w> LCD_WIDTH)   *w = LCD_WIDTH - *x;
    }

rbe2012 wrote: I don't find the place where the position is changed...
(still working on it)

diff -r 5bf25ae07f01 src/pages/common/_main_layout.c
--- a/src/pages/common/_main_layout.c   Sat Nov 30 22:27:46 2013 -0800
+++ b/src/pages/common/_main_layout.c   Sun Dec 01 13:13:05 2013 +0100
@@ -16,6 +16,7 @@
 #include "main_layout.h"

 extern int GetWidgetLoc(void *ptr, u16 *x, u16 *y, u16 *w, u16 *h);
+extern void AdjustIconSize(u16 *x, u16 *y, u16 *h, u16 *w);

 static const char *label_cb(guiObject_t *obj, const void *data);
 static void touch_cb(guiObject_t *obj, s8 press, const void *data);
@@ -124,6 +125,8 @@
     lp.selected_x = ELEM_X(pc.elem[idx]);
     lp.selected_y = ELEM_Y(pc.elem[idx]);
     GetElementSize(ELEM_TYPE(pc.elem[idx]), &lp.selected_w, &lp.selected_h);
+    if (ELEM_TYPE(pc.elem[idx]) == ELEM_MODELICO)
+        AdjustIconSize(&lp.selected_x, &lp.selected_y, &lp.selected_h, &lp.selected_w);
     GUI_Redraw((guiObject_t *)&gui->x);
     GUI_Redraw((guiObject_t *)&gui->y);
 }
diff -r 5bf25ae07f01 src/pages/common/_main_page.c
--- a/src/pages/common/_main_page.c     Sat Nov 30 22:27:46 2013 -0800
+++ b/src/pages/common/_main_page.c     Sun Dec 01 13:13:05 2013 +0100
@@ -265,6 +265,12 @@
     }
 }

+void AdjustIconSize(u16 *x, u16 *y, u16 *h, u16 *w)
+{
+    if (*y + *h > LCD_HEIGHT) *h = LCD_HEIGHT - *y;
+    if (*x + *w> LCD_WIDTH)   *w = LCD_WIDTH - *x;
+}
+
 int GetWidgetLoc(struct elem *elem, u16 *x, u16 *y, u16 *w, u16 *h)
 {
     *y = ELEM_Y(*elem);
@@ -275,12 +281,8 @@
         return 0;
     *x = ELEM_X(*elem);
     GetElementSize(type, w, h);
-    if (type == ELEM_MODELICO) {
-       if (*h > LCD_HEIGHT - 32) *h = LCD_HEIGHT - 32;
-       if (*w > LCD_WIDTH)       *w = LCD_WIDTH;
-       if (*x + *w > LCD_WIDTH)  *x = LCD_WIDTH - *w;
-       if (*y + *h > LCD_HEIGHT) *y = LCD_HEIGHT - *h;
-    }
+    if (type == ELEM_MODELICO)
+        AdjustIconSize(x, y, h, w);
     return 1;
 }

PhracturedBlue wrote: I could add a link in the message that is at the top of every page (where the Copyright notice is) and move the instructions into an 'Article'

rbe2012 wrote: Btw, has anyone else seen the behavior described by HappyHarry? Or something similar which could be caused by memory issues (like crashes, reboots, confused screens)?